-
Notifications
You must be signed in to change notification settings - Fork 350
feat: 音声の長さ表示機能の追加 #2868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 音声の長さ表示機能の追加 #2868
Conversation
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ: |
|
@Hiroshiba |
sevenc-nanashi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
レビュー中の考え:
このPRとは別で、1番上から足していって何秒から始まるかみたいなものを出せると便利そう。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a feature to display the estimated playback duration for each audio item in the Talk editor. The implementation calculates audio length from AudioQuery data and includes a settings toggle to control visibility.
- Adds
calculateAudioLengthfunction to compute audio duration from AudioQuery data - Implements UI display of audio duration next to each text field
- Adds new setting
showAudioLengthwith ON/OFF toggle in the settings dialog
Reviewed changes
Copilot reviewed 7 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/store/audioGenerate.ts | Adds calculateAudioLength function to compute audio duration in seconds from EditorAudioQuery |
| src/components/Talk/AudioCell.vue | Implements UI to display audio duration with proper engine support checks; includes unrelated type casting change |
| src/components/Dialog/SettingDialog/SettingDialog.vue | Adds toggle control for showAudioLength setting; includes unrelated type casting change |
| src/store/setting.ts | Adds showAudioLength to settingStoreState and rootMiscSettingKeys |
| src/type/preload.ts | Refactors schema definitions, adds showAudioLength to rootMiscSettingSchema, and reorganizes type exports |
| tests/unit/backend/common/snapshots/configManager.spec.ts.snap | Updates snapshot to include new showAudioLength setting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| outputSamplingRate: 24000, | ||
| outputStereo: false, | ||
| kana: "", | ||
| } as unknown as EditorAudioQuery; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as unknownは不要そう?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f76dd83 にて修正しました。
| prePhonemeLength: 0.1, | ||
| postPhonemeLength: 0.1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre/postPhonomeLengthのテストもあったほうがよさそう。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b83ee32 にて追加しました。
Co-authored-by: Nanashi. <sevenc7c@sevenc7c.com>
sevenc-nanashi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!ありがとうございます。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@takusea おお、確認等ありがとうございます!! 表示ズレは僕も結構気になってました! これ何か良い方法あるんですかね~~~~ |

内容
各オーディオアイテムの推定再生時間を表示する機能を追加します。
関連 Issue
close #2852
スクリーンショット・動画など
その他